Re: [PATCH v2 00/11] fix "git reflog expire" race & get rid of EISDIR in refs API
- From
Jeff King <peff@peff.net>
- Date
- Jul 17, 2021, 02:34 UTC
- Message-ID
- <YPJBsnrPTEXvYG7I@coredump.intra.peff.net>
- In-Reply-To
- <cover-00.11-00000000000-20210716T140631Z-avarab@gmail.com>
On Fri, Jul 16, 2021 at 04:12:56PM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 8 quoted lines
> builtin/reflog.c | 17 +++--- > reflog-walk.c | 3 +- > refs.c | 5 +- > refs.h | 4 +- > refs/debug.c | 10 ++-- > refs/files-backend.c | 122 ++++++++++-------------------------------- > refs/packed-backend.c | 5 ++ > 7 files changed, 54 insertions(+), 112 deletions(-)
The diffstat certainly looks nice. :)
I left a few comments on specific patches, mostly just little things. The ones I didn't comment on looked good to me. Overall, it seems like a very nice cleanup. Thanks for putting it together.
-Peff