[PATCH v5 02/13] refs/files: remove unused REF_DELETING in lock_ref_oid_basic()
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Aug 23, 2021, 11:36 UTC
- Message-ID
- <patch-v5-02.13-a20548c1a4d-20210823T113115Z-avarab@gmail.com>
- In-Reply-To
- <cover-v5-00.13-00000000000-20210823T113115Z-avarab@gmail.com>
The lock_ref_oid_basic() function has gradually been replaced by most callers no longer performing a low-level "acquire lock, update and release", and instead using the ref transaction API. So there are only 4 remaining callers of lock_ref_oid_basic().
None of those callers pass REF_DELETING anymore, the last caller went away in 92b1551b1d (refs: resolve symbolic refs first, 2016-04-25).
Before that we'd refactored and moved this code in:
- 8df4e511387 (struct ref_update: move "have_old" into "flags", 2015-02-17)
- 7bd9bcf372d (refs: split filesystem-based refs code into a new file, 2015-11-09)
- 165056b2fc (lock_ref_for_update(): new function, 2016-04-24)
We then finally stopped using it in 92b1551b1d (noted above). So let's remove the handling of this parameter.
By itself this change doesn't benefit us much, but it's the start of even more removal of unused code in and around this function in subsequent commits.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- refs/files-backend.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/refs/files-backend.c b/refs/files-backend.c index 677b7e4cdd2..326f0224218 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -934,8 +934,6 @@ static struct ref_lock *lock_ref_oid_basic(struct files_ref_store *refs, if (mustexist) resolve_flags |= RESOLVE_REF_READING; - if (flags & REF_DELETING) - resolve_flags |= RESOLVE_REF_ALLOW_BAD_NAME; files_ref_path(refs, &ref_file, refname); resolved = !!refs_resolve_ref_unsafe(&refs->base,
-- 2.33.0.662.g438caf9576d