Re: [PATCH v4 08/11] reflog expire: don't lock reflogs using previously seen OID

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 4, 2021, 09:56 UTC
Message-ID: <8735rpo7lc.fsf@evledraar.gmail.com>
In-Reply-To: <xmqqeebbwyeo.fsf@gitster.g>

On Mon, Aug 02 2021, Junio C Hamano wrote:

Show 21 quoted lines

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
> [...]
>> @@ -3111,6 +3113,7 @@ static int files_reflog_expire(struct ref_store *ref_store,
>>  		}
>>  	}
>>  
>> +	assert(!unused_oid);
>>  	(*prepare_fn)(refname, oid, cb.policy_cb);
>>  	refs_for_each_reflog_ent(ref_store, refname, expire_reflog_ent, &cb);
>>  	(*cleanup_fn)(cb.policy_cb);
>
> The preference in this codebase is
>
> 	ptr_to_function(params);
>
> over
>
> 	(*ptr_to_function)(params);
>
> Once it is written and committed, it is not worth changing, but just
> for the record...

Indeed, in this series I don't touch that (except items on the argument list), so refactoring that just for changing the syntax here didn't seem worth it.