Re: [PATCH v2 06/11] refs API: pass the "lock OID" to reflog "prepare"
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jul 19, 2021, 19:21 UTC
- Message-ID
- <87eebuw1lz.fsf@evledraar.gmail.com>
- In-Reply-To
- <xmqqfswanu4m.fsf@gitster.g>
On Mon, Jul 19 2021, Junio C Hamano wrote:
Show 9 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > >> Don't pass the object ID we pass into reflog_expire() back to the >> caller, but rather our locked OID. >> >> As the assert shows these two were the same thing in practice as we'd > > It is unclear which assert you refer to, but a call to verify_lock() > near the end of lock_ref_oid_basic() ensures this, I presume?
It's something I omitted by mistake, already fixed in the soon-to-be-sent re-roll, sorry.