Re: [PATCH v2 09/11] reflog expire: don't lock reflogs using previously seen OID
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Aug 17, 2021, 13:35 UTC
- Message-ID
- <CAFQ2z_MhNgimn=7qcu-G823X=yTRT3xXrDP7qRiELShXY9A3AA@mail.gmail.com>
- In-Reply-To
- <patch-09.11-60d6cf342fc-20210716T140631Z-avarab@gmail.com>
On Fri, Jul 16, 2021 at 4:13 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> - status |= reflog_expire(e->reflog, &e->oid, flags, > + status |= reflog_expire(e->reflog, NULL, flags, > reflog_expiry_prepare,
this causes reflog_expiry_prepare() to be called with a NULL oid. I'm seeing a crash in do_lookup_replace_object() because of this in t0031-reftable.sh.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado