Re: [PATCH v2 09/11] t-reftable-block: add tests for log blocks

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2024, 16:13 UTC
Message-ID: <xmqqle0p26s3.fsf@gitster.g>
In-Reply-To: <ZsWXF_zJTIsp8XOE@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

Show 9 quoted lines

>> +	REFTABLE_CALLOC_ARRAY(block.data, block_size);
>> +	block.len = block_size;
>> +	block.source = malloc_block_source();
>> +	block_writer_init(&bw, BLOCK_TYPE_LOG, block.data, block_size,
>> +			  header_off, hash_size(GIT_SHA1_FORMAT_ID));
>
> Nit: instead of a `malloc_block_source()`, you may use
> `block_source_from_strbuf()`. The former will go away with the patch
> series at [1].

I noticed that need for rewriting while merging the topic. If the patch uses the surviving alternative, that's one fewer thing I have to worry about ;-).

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.