git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH v3 00/11] t: port reftable/block_test.c to the unit testing framework

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 22, 2024, 18:01 UTC
Message-ID
<xmqqwmk8qvxe.fsf@gitster.g>
In-Reply-To
<ZsbdFU9aBQvqE3pb@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 6 quoted lines
>> - Use block_source_from_strbuf() instead of malloc_block_source()
>>   in log, obj, and index block tests (patches 9, 10, 11).
>> - Remove a line that causes a memory leak in obj test (patch 10).
>
> This addresses all comments I had on the preceding version and
> plugs the memory leak. So this looks good to me, thanks!
Thanks, both.  Let me mark it for 'next', then.
Previous: Patrick Steinhardt
Message 53 of 53 in “t: port reftable/block_test.c to the unit testing framework”
  1. Chandra PratapAug 14, 2024
  2. 01/10 t: move reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 14, 2024
  3. 02/10 t-reftable-block: release used block readerChandra Pratap, Aug 14, 2024
  4. Patrick SteinhardtAug 15, 2024
  5. Chandra PratapAug 15, 2024
  6. 03/10 t-reftable-block: use reftable_record_equal() instead of check_str()Chandra Pratap, Aug 14, 2024
  7. Patrick SteinhardtAug 15, 2024
  8. 04/10 t-reftable-block: use reftable_record_key() instead of strbuf_addstr()Chandra Pratap, Aug 14, 2024
  9. Patrick SteinhardtAug 15, 2024
  10. 05/10 t-reftable-block: use block_iter_reset() instead of block_iter_close()Chandra Pratap, Aug 14, 2024
  11. Patrick SteinhardtAug 15, 2024
  12. 06/10 t-reftable-block: use xstrfmt() instead of xstrdup()Chandra Pratap, Aug 14, 2024
  13. 07/10 t-reftable-block: remove unnecessary variable 'j'Chandra Pratap, Aug 14, 2024
  14. 08/10 t-reftable-block: add tests for log blocksChandra Pratap, Aug 14, 2024
  15. Patrick SteinhardtAug 15, 2024
  16. Chandra PratapAug 15, 2024
  17. Patrick SteinhardtAug 16, 2024
  18. 09/10 t-reftable-block: add tests for obj blocksChandra Pratap, Aug 14, 2024
  19. Patrick SteinhardtAug 15, 2024
  20. Chandra PratapAug 15, 2024
  21. Patrick SteinhardtAug 16, 2024
  22. 10/10 t-reftable-block: add tests for index blocksChandra Pratap, Aug 14, 2024
  23. Patrick SteinhardtAug 15, 2024
  24. [GSoC][PATCH v2 00/11] t: port reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 16, 2024
  25. 01/11 t: move reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 16, 2024
  26. 02/11 t: harmonize t-reftable-block.c with coding guidelinesChandra Pratap, Aug 16, 2024
  27. 03/11 t-reftable-block: release used block readerChandra Pratap, Aug 16, 2024
  28. 04/11 t-reftable-block: use reftable_record_equal() instead of check_str()Chandra Pratap, Aug 16, 2024
  29. 05/11 t-reftable-block: use reftable_record_key() instead of strbuf_addstr()Chandra Pratap, Aug 16, 2024
  30. 06/11 t-reftable-block: use block_iter_reset() instead of block_iter_close()Chandra Pratap, Aug 16, 2024
  31. 07/11 t-reftable-block: use xstrfmt() instead of xstrdup()Chandra Pratap, Aug 16, 2024
  32. 08/11 t-reftable-block: remove unnecessary variable 'j'Chandra Pratap, Aug 16, 2024
  33. 09/11 t-reftable-block: add tests for log blocksChandra Pratap, Aug 16, 2024
  34. Patrick SteinhardtAug 21, 2024
  35. Junio C HamanoAug 21, 2024
  36. 10/11 t-reftable-block: add tests for obj blocksChandra Pratap, Aug 16, 2024
  37. Chandra PratapAug 16, 2024
  38. 11/11 t-reftable-block: add tests for index blocksChandra Pratap, Aug 16, 2024
  39. Chandra PratapAug 21, 2024
  40. [GSoC][PATCH v3 00/11] t: port reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 21, 2024
  41. 01/11 t: move reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 21, 2024
  42. 02/11 t: harmonize t-reftable-block.c with coding guidelinesChandra Pratap, Aug 21, 2024
  43. 03/11 t-reftable-block: release used block readerChandra Pratap, Aug 21, 2024
  44. 04/11 t-reftable-block: use reftable_record_equal() instead of check_str()Chandra Pratap, Aug 21, 2024
  45. 05/11 t-reftable-block: use reftable_record_key() instead of strbuf_addstr()Chandra Pratap, Aug 21, 2024
  46. 06/11 t-reftable-block: use block_iter_reset() instead of block_iter_close()Chandra Pratap, Aug 21, 2024
  47. 07/11 t-reftable-block: use xstrfmt() instead of xstrdup()Chandra Pratap, Aug 21, 2024
  48. 08/11 t-reftable-block: remove unnecessary variable 'j'Chandra Pratap, Aug 21, 2024
  49. 09/11 t-reftable-block: add tests for log blocksChandra Pratap, Aug 21, 2024
  50. 10/11 t-reftable-block: add tests for obj blocksChandra Pratap, Aug 21, 2024
  51. 11/11 t-reftable-block: add tests for index blocksChandra Pratap, Aug 21, 2024
  52. Patrick SteinhardtAug 22, 2024
  53. Junio C HamanoAug 22, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.