From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 21 Aug 2024 16:13:32 GMT
Subject: Re: [PATCH v2 09/11] t-reftable-block: add tests for log blocks
Message-ID: <xmqqle0p26s3.fsf@gitster.g>
In-Reply-To: <ZsWXF_zJTIsp8XOE@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

>> +	REFTABLE_CALLOC_ARRAY(block.data, block_size);
>> +	block.len = block_size;
>> +	block.source = malloc_block_source();
>> +	block_writer_init(&bw, BLOCK_TYPE_LOG, block.data, block_size,
>> +			  header_off, hash_size(GIT_SHA1_FORMAT_ID));
>
> Nit: instead of a `malloc_block_source()`, you may use
> `block_source_from_strbuf()`. The former will go away with the patch
> series at [1].

I noticed that need for rewriting while merging the topic.  If the
patch uses the surviving alternative, that's one fewer thing I have
to worry about ;-).

Thanks.