git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 10/11] t-reftable-block: add tests for obj blocks

From
CPChandra Pratap <chandrapratap3519@gmail.com>
Date
Aug 16, 2024, 17:25 UTC
Message-ID
<20240816175414.5169-11-chandrapratap3519@gmail.com>
In-Reply-To
<20240816175414.5169-1-chandrapratap3519@gmail.com>

In the current testing setup, block operations are left unexercised for obj blocks. Add a test that exercises these operations for obj blocks.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
---
 t/unit-tests/t-reftable-block.c | 82 +++++++++++++++++++++++++++++++++
 1 file changed, 82 insertions(+)
diff --git a/t/unit-tests/t-reftable-block.c b/t/unit-tests/t-reftable-block.c
index 1256c7df6a..7671a40969 100644
--- a/t/unit-tests/t-reftable-block.c
+++ b/t/unit-tests/t-reftable-block.c
@@ -190,9 +190,91 @@ static void t_log_block_read_write(void)
 		reftable_record_release(&recs[i]);
 }
 
+static void t_obj_block_read_write(void)
+{
+	const int header_off = 21;
+	struct reftable_record recs[30];
+	const size_t N = ARRAY_SIZE(recs);
+	const size_t block_size = 1024;
+	struct reftable_block block = { 0 };
+	struct block_writer bw = {
+		.last_key = STRBUF_INIT,
+	};
+	struct reftable_record rec = {
+		.type = BLOCK_TYPE_OBJ,
+	};
+	size_t i = 0;
+	int ret;
+	struct block_reader br = { 0 };
+	struct block_iter it = BLOCK_ITER_INIT;
+	struct strbuf want = STRBUF_INIT;
+
+	REFTABLE_CALLOC_ARRAY(block.data, block_size);
+	block.len = block_size;
+	block.source = malloc_block_source();
+	block_writer_init(&bw, BLOCK_TYPE_OBJ, block.data, block_size,
+			  header_off, hash_size(GIT_SHA1_FORMAT_ID));
+
+	for (i = 0; i < N; i++) {
+		uint8_t bytes[] = { i, i + 1, i + 2, i + 3, i + 5 }, *allocated;
+		allocated = reftable_malloc(ARRAY_SIZE(bytes));
+		DUP_ARRAY(allocated, bytes, ARRAY_SIZE(bytes));
+
+		rec.u.obj.hash_prefix = allocated;
+		rec.u.obj.hash_prefix_len = 5;
+
+		recs[i] = rec;
+		ret = block_writer_add(&bw, &rec);
+		rec.u.obj.hash_prefix = NULL;
+		rec.u.obj.hash_prefix_len = 0;
+		check_int(ret, ==, 0);
+	}
+
+	ret = block_writer_finish(&bw);
+	check_int(ret, >, 0);
+
+	block_writer_release(&bw);
+
+	block_reader_init(&br, &block, header_off, block_size, GIT_SHA1_RAWSZ);
+
+	block_iter_seek_start(&it, &br);
+
+	for (i = 0; ; i++) {
+		ret = block_iter_next(&it, &rec);
+		check_int(ret, >=, 0);
+		if (ret > 0) {
+			check_int(i, ==, N);
+			break;
+		}
+		check(reftable_record_equal(&recs[i], &rec, GIT_SHA1_RAWSZ));
+	}
+
+	for (i = 0; i < N; i++) {
+		block_iter_reset(&it);
+		reftable_record_key(&recs[i], &want);
+
+		ret = block_iter_seek_key(&it, &br, &want);
+		check_int(ret, ==, 0);
+
+		ret = block_iter_next(&it, &rec);
+		check_int(ret, ==, 0);
+
+		check(reftable_record_equal(&recs[i], &rec, GIT_SHA1_RAWSZ));
+	}
+
+	block_reader_release(&br);
+	block_iter_close(&it);
+	reftable_record_release(&rec);
+	reftable_block_done(&br.block);
+	strbuf_release(&want);
+	for (i = 0; i < N; i++)
+		reftable_record_release(&recs[i]);
+}
+
 int cmd_main(int argc, const char *argv[])
 {
 	TEST(t_log_block_read_write(), "read-write operations on log blocks work");
+	TEST(t_obj_block_read_write(), "read-write operations on obj blocks work");
 	TEST(t_ref_block_read_write(), "read-write operations on ref blocks work");
 
 	return test_done();
-- 
2.45.GIT
Previous: Junio C HamanoNext: Chandra Pratap
Message 36 of 53 in “t: port reftable/block_test.c to the unit testing framework”
  1. Chandra PratapAug 14, 2024
  2. 01/10 t: move reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 14, 2024
  3. 02/10 t-reftable-block: release used block readerChandra Pratap, Aug 14, 2024
  4. Patrick SteinhardtAug 15, 2024
  5. Chandra PratapAug 15, 2024
  6. 03/10 t-reftable-block: use reftable_record_equal() instead of check_str()Chandra Pratap, Aug 14, 2024
  7. Patrick SteinhardtAug 15, 2024
  8. 04/10 t-reftable-block: use reftable_record_key() instead of strbuf_addstr()Chandra Pratap, Aug 14, 2024
  9. Patrick SteinhardtAug 15, 2024
  10. 05/10 t-reftable-block: use block_iter_reset() instead of block_iter_close()Chandra Pratap, Aug 14, 2024
  11. Patrick SteinhardtAug 15, 2024
  12. 06/10 t-reftable-block: use xstrfmt() instead of xstrdup()Chandra Pratap, Aug 14, 2024
  13. 07/10 t-reftable-block: remove unnecessary variable 'j'Chandra Pratap, Aug 14, 2024
  14. 08/10 t-reftable-block: add tests for log blocksChandra Pratap, Aug 14, 2024
  15. Patrick SteinhardtAug 15, 2024
  16. Chandra PratapAug 15, 2024
  17. Patrick SteinhardtAug 16, 2024
  18. 09/10 t-reftable-block: add tests for obj blocksChandra Pratap, Aug 14, 2024
  19. Patrick SteinhardtAug 15, 2024
  20. Chandra PratapAug 15, 2024
  21. Patrick SteinhardtAug 16, 2024
  22. 10/10 t-reftable-block: add tests for index blocksChandra Pratap, Aug 14, 2024
  23. Patrick SteinhardtAug 15, 2024
  24. [GSoC][PATCH v2 00/11] t: port reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 16, 2024
  25. 01/11 t: move reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 16, 2024
  26. 02/11 t: harmonize t-reftable-block.c with coding guidelinesChandra Pratap, Aug 16, 2024
  27. 03/11 t-reftable-block: release used block readerChandra Pratap, Aug 16, 2024
  28. 04/11 t-reftable-block: use reftable_record_equal() instead of check_str()Chandra Pratap, Aug 16, 2024
  29. 05/11 t-reftable-block: use reftable_record_key() instead of strbuf_addstr()Chandra Pratap, Aug 16, 2024
  30. 06/11 t-reftable-block: use block_iter_reset() instead of block_iter_close()Chandra Pratap, Aug 16, 2024
  31. 07/11 t-reftable-block: use xstrfmt() instead of xstrdup()Chandra Pratap, Aug 16, 2024
  32. 08/11 t-reftable-block: remove unnecessary variable 'j'Chandra Pratap, Aug 16, 2024
  33. 09/11 t-reftable-block: add tests for log blocksChandra Pratap, Aug 16, 2024
  34. Patrick SteinhardtAug 21, 2024
  35. Junio C HamanoAug 21, 2024
  36. 10/11 t-reftable-block: add tests for obj blocksChandra Pratap, Aug 16, 2024
  37. Chandra PratapAug 16, 2024
  38. 11/11 t-reftable-block: add tests for index blocksChandra Pratap, Aug 16, 2024
  39. Chandra PratapAug 21, 2024
  40. [GSoC][PATCH v3 00/11] t: port reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 21, 2024
  41. 01/11 t: move reftable/block_test.c to the unit testing frameworkChandra Pratap, Aug 21, 2024
  42. 02/11 t: harmonize t-reftable-block.c with coding guidelinesChandra Pratap, Aug 21, 2024
  43. 03/11 t-reftable-block: release used block readerChandra Pratap, Aug 21, 2024
  44. 04/11 t-reftable-block: use reftable_record_equal() instead of check_str()Chandra Pratap, Aug 21, 2024
  45. 05/11 t-reftable-block: use reftable_record_key() instead of strbuf_addstr()Chandra Pratap, Aug 21, 2024
  46. 06/11 t-reftable-block: use block_iter_reset() instead of block_iter_close()Chandra Pratap, Aug 21, 2024
  47. 07/11 t-reftable-block: use xstrfmt() instead of xstrdup()Chandra Pratap, Aug 21, 2024
  48. 08/11 t-reftable-block: remove unnecessary variable 'j'Chandra Pratap, Aug 21, 2024
  49. 09/11 t-reftable-block: add tests for log blocksChandra Pratap, Aug 21, 2024
  50. 10/11 t-reftable-block: add tests for obj blocksChandra Pratap, Aug 21, 2024
  51. 11/11 t-reftable-block: add tests for index blocksChandra Pratap, Aug 21, 2024
  52. Patrick SteinhardtAug 22, 2024
  53. Junio C HamanoAug 22, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.