Re: [PATCH v5 2/5] ref-cache: remove unused function 'find_ref_entry()'

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 17, 2025, 20:32 UTC
Message-ID: <xmqqldom5zjp.fsf@gitster.g>
In-Reply-To: <CAOLa=ZRqLgdnUz4Eeof0qdD_RkBYOKOT4oOoXEb0P386KQ0g8w@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 25 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>> The 'find_ref_entry' function is no longer used, so remove it.
>>
>> If my spelunking is correct, ba1c052f (ref_store: implement
>> `refs_peel_ref()` generically, 2017-09-25) is the commit that
>> removed the last caller of it.  Which may be worth noting here.
>>
>
> Indeed, I could also verify this by running
>
> $ git log -S find_ref_entry --oneline
> 2c90b85801 ref-cache: remove unused function 'find_ref_entry()'
> ba1c052fa6 ref_store: implement `refs_peel_ref()` generically
> 9939b33d6a packed-backend: rip out some now-unused code
> ....
>
> And looking at `ba1c052fa6`. I should've done this before. But thanks
> for the digging!
>
> I plan to address a few comments on this version, but I also see that
> you've merged it to master. Should I raise followups for noteworthy
> changes or a new version?

You mean it is now in 'next'? Yes, please give incremental patches. Finding some more gotchas even after v5 is a sign that they are tricky enough that deserve separate explanation from the main part of the series. And I think the msan one Kyle and Peff found is also tricky enough that evaded reviewers' eyes.

Thanks.