Re: [PATCH v2 4/4] for-each-ref: introduce a '--skip-until' option

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jul 7, 2025, 18:31 UTC
Message-ID: <CAOLa=ZSSQJxm04x1RArP2VxbbxE5ySGiYZ+p-3PaUOu9hXUt0w@mail.gmail.com>
In-Reply-To: <xmqq5xg4588e.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> +	if (filter.seek && sorting_options.nr > 1)
>> +		die(_("cannot use --skip-until custom sort options"));
>
> Missing "with" before "custom sort".
>

Thanks, will fix in the next version.

Show 6 quoted lines

> When I commented on the previous iteration about sorting, I didn't
> mean to suggest making them incompatible---it may have some use case
> to grab a batch out of the underlying refstore, sort refs in that
> batch, and then show them.  But from usability's point of view, I
> tend to agree with this design decision.  Such an unnatural batching
> and sorting operation is probably not worth supporting.

I think so too, there might be some usecase, when that usecase is more concrete we can probably re-visit this.

For now, it is confusing and it is just easier to not support them together.