Re: [PATCH v4 3/4] refs: selectively set prefix in the seek functions

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jul 15, 2025, 08:19 UTC
Message-ID: <CAOLa=ZRgrfs8vip20QuNNkx9CmpUK392EV0vBkqu3HCyn4fXxQ@mail.gmail.com>
In-Reply-To: <CAP8UFD06KKF0A0WjBSw77A7fKp_pGJGVyw-OPd8-X92h=RSF+w@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

Show 16 quoted lines

> On Fri, Jul 11, 2025 at 6:20 PM Karthik Nayak <karthik.188@gmail.com> wrote:
>
>> diff --git a/refs/refs-internal.h b/refs/refs-internal.h
>> index 03f5df04d5..90de7837f8 100644
>> --- a/refs/refs-internal.h
>> +++ b/refs/refs-internal.h
>> @@ -353,11 +353,12 @@ void base_ref_iterator_init(struct ref_iterator *iter,
>>  typedef int ref_iterator_advance_fn(struct ref_iterator *ref_iterator);
>>
>>  /*
>> - * Seek the iterator to the first reference matching the given prefix. Should
>> - * behave the same as if a new iterator was created with the same prefix.
>> + * Seek the iterator to the first matching reference. If set_prefix is set,
>
> s/If set_prefix is set/If the REF_ITERATOR_SEEK_SET_PREFIX flag is set/
>

Will change, thanks.

Show 5 quoted lines

>> + * it would behave the same as if a new iterator was created with the same
>> + * prefix.
>
> Maybe: s/with the same prefix/at the same reference/
>

Changed it to

  If the REF_ITERATOR_SEEK_SET_PREFIX flag is set, it would behave the
  same as if a new iterator was created with the provided refname as prefix.

>>   */
>>  typedef int ref_iterator_seek_fn(struct ref_iterator *ref_iterator,
>> -                                const char *prefix);
>> +                                const char *refname, unsigned int flags);