Re: [PATCH v4 3/4] refs: selectively set prefix in the seek functions

From: Christian Couder <christian.couder@gmail.com>
Date: Jul 14, 2025, 10:34 UTC
Message-ID: <CAP8UFD06KKF0A0WjBSw77A7fKp_pGJGVyw-OPd8-X92h=RSF+w@mail.gmail.com>
In-Reply-To: <20250711-306-git-for-each-ref-pagination-v4-3-ed3303ad5b89@gmail.com>

On Fri, Jul 11, 2025 at 6:20 PM Karthik Nayak <karthik.188@gmail.com> wrote:

Show 11 quoted lines

> diff --git a/refs/refs-internal.h b/refs/refs-internal.h
> index 03f5df04d5..90de7837f8 100644
> --- a/refs/refs-internal.h
> +++ b/refs/refs-internal.h
> @@ -353,11 +353,12 @@ void base_ref_iterator_init(struct ref_iterator *iter,
>  typedef int ref_iterator_advance_fn(struct ref_iterator *ref_iterator);
>
>  /*
> - * Seek the iterator to the first reference matching the given prefix. Should
> - * behave the same as if a new iterator was created with the same prefix.
> + * Seek the iterator to the first matching reference. If set_prefix is set,

s/If set_prefix is set/If the REF_ITERATOR_SEEK_SET_PREFIX flag is set/

> + * it would behave the same as if a new iterator was created with the same
> + * prefix.

Maybe: s/with the same prefix/at the same reference/

>   */
>  typedef int ref_iterator_seek_fn(struct ref_iterator *ref_iterator,
> -                                const char *prefix);
> +                                const char *refname, unsigned int flags);