Re: [PATCH v2 4/4] for-each-ref: introduce a '--skip-until' option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 7, 2025, 15:30 UTC
- Message-ID
- <xmqq5xg4588e.fsf@gitster.g>
- In-Reply-To
- <20250704-306-git-for-each-ref-pagination-v2-4-bcde14acdd81@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
> + if (filter.seek && sorting_options.nr > 1)
> + die(_("cannot use --skip-until custom sort options"));Missing "with" before "custom sort".
When I commented on the previous iteration about sorting, I didn't mean to suggest making them incompatible---it may have some use case to grab a batch out of the underlying refstore, sort refs in that batch, and then show them. But from usability's point of view, I tend to agree with this design decision. Such an unnatural batching and sorting operation is probably not worth supporting.