Re: [PATCH v2 0/4] for-each-ref: introduce seeking functionality via '--skip-until'
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Jul 8, 2025, 11:39 UTC
- Message-ID
- <CAOLa=ZRodyDB5_ZESeDe43Et29dXWNV2+RcNJ14D8BAp7WtJ_g@mail.gmail.com>
- In-Reply-To
- <3d95d37c-7352-4e57-8d50-6fd4fcb77095@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 13 quoted lines
> On 07/07/2025 09:59, Karthik Nayak wrote: >> Junio C Hamano <gitster@pobox.com> writes: >> >>> Karthik Nayak <karthik.188@gmail.com> writes: >> I do agree, I was modelling this after what would be the best approach >> within the Git codebase. > > That was my fear when I asked about using a numeric offset. Patrick has > made a principled argument for using a ref name rather than a numeric > ofsset - I think you should build the motivation for this series around > that and the documentation should explain the implications of references > being added and deleted while paging them. >
Yeah, I'll add something on those lines in the next version. I do appreciate these checks/questions.
>> With that I think '--start-after' sounds like the best option. I'll >> modify for the next version accordingly. > That sounds like a good name >
Thanks!
> Thanks > > Phillip