Re: [PATCH] pretty-print: de-tabify indented logs to make things line up properly

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 16, 2016, 21:37 UTC
Message-ID: <xmqqk2l23xzc.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+55aFwbNXJnwEYrKE5dDRk_6eZeGT6Z11uSQS8RmCSq43PkdA@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 10 quoted lines

> On Wed, Mar 16, 2016 at 12:47 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Strangely running t4201 with your patch (without any squashing)
>> seems to show a breakage in shortlog.  I won't be able to come back
>> to this topic for at least a few hours, so this is just a single bit
>> "breaks" report, without "how and why" analysis, sorry.
>
> It's because those things have tabs in their first line, so the output
> now differs from the expected one exactly because of the tab-vs-space
> expansion.

What surprised me was that this new expand logic triggered for shortlog, actually. I somehow assumed the caller that called de-tabify helper was only called for --pretty=medium.