Re: [PATCH 4/4] pretty-print: add --pretty=noexpand

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 18, 2016, 05:36 UTC
Message-ID: <CA+55aFw=obdDSTS98GQi6ER3RgAxD61xDmXYVeEX=a3GKM6SOg@mail.gmail.com>
In-Reply-To: <20160318050807.GC22327@sigill.intra.peff.net>

On Thu, Mar 17, 2016 at 10:08 PM, Jeff King <peff@peff.net> wrote:

>
> Hmm. Isn't "expand tabs" orthogonal to the rest of the pretty format?
> That is, couldn't one want "--pretty=fuller, but with tabs expanded"?

Yeah, you are right, one easily could. And in fact I end up doing "fuller" myself occasionally, because I check peoples commit timestamps (some people have a nasty habit of rebasing when they shouldn't).

So it's not just the medium format that would want detab by default, it's "full" and "fuller" too (but probably not "raw": that indents the message too, but the only real reason to use "raw" is for scripting).

So it would probably be better to make it a separate flag, and not tie it to a particular log format (and just make the log format set the default).

               Linus