Re: [PATCH v3 0/5] Expanding tabs in "git log" output
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 24, 2016, 05:17 UTC
- Message-ID
- <xmqqh9fwbgku.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160324005849.GA8167@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
> On Wed, Mar 23, 2016 at 04:23:41PM -0700, Junio C Hamano wrote: > >> So here is the third try (previous round is found at $gmane/289166 >> and the very first one is at $gmane/288987). > > Is the plan to merge these as-is? The ordering is a bit funny (introduce > breakage, then repair it), and I think the first patch still breaks > t4201.8 (which is then repaired in the fourth one).
I do not have a firm plan yet. This was one of those "during the pre-release freeze, instead of reviewing shiny new toys by others too early, spend leftover time to tie loose ends" attempts ;-)
I'd agree that the "final" version should do our usual "progressive improvement, never stepping back one and then forward two", but I wanted to see what the endgame state would look like first, and by doing the incremental "the first one gets it 80% right, and fix it up with follow-up patches" I didn't have to worry about at what point I need to take the authorship of which patch.