Re: [PATCH v3 0/5] Expanding tabs in "git log" output

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 23, 2016, 23:47 UTC
Message-ID: <CA+55aFxBhTK0sa9qfXus3+ct7gZ+BV1aODF7xawQF3crQYYGJQ@mail.gmail.com>
In-Reply-To: <1458775426-2215-1-git-send-email-gitster@pobox.com>

On Wed, Mar 23, 2016 at 4:23 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> So here is the third try (previous round is found at $gmane/289166
> and the very first one is at $gmane/288987).
>
> The first three patches are essentially the same as v2.  The last
> two updates how the tab-expansion is internally controlled:

I tested this (as it in in 'pu', rather than applying the patches), and it all seems to work fine. So Ack.

And I agree that it would be good if all the commit printout logic was unified rather than having some ad-hoc "let's just set the format", but I think that's a separate cleanup.

It might be more regular to have that "--expand-tabs" flag too (which would then work with the email and raw formats), but I don't see any actual real use for it so it really doesn't matter.

          Linus