Re: [PATCH] pretty-print: de-tabify indented logs to make things line up properly

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 16, 2016, 19:59 UTC
Message-ID: <CA+55aFwbNXJnwEYrKE5dDRk_6eZeGT6Z11uSQS8RmCSq43PkdA@mail.gmail.com>
In-Reply-To: <xmqqoaae4340.fsf@gitster.mtv.corp.google.com>

On Wed, Mar 16, 2016 at 12:47 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

>
> Strangely running t4201 with your patch (without any squashing)
> seems to show a breakage in shortlog.  I won't be able to come back
> to this topic for at least a few hours, so this is just a single bit
> "breaks" report, without "how and why" analysis, sorry.

It's because those things have tabs in their first line, so the output now differs from the expected one exactly because of the tab-vs-space expansion.

The wrapping logic is then also different, because the .wrapping code does the tabs as "align to 8 chars" while the new code does tabs as "align to 8 chars modulo the indent offset".

I only looked at the first case, but I assume the others are just more of the same. We'd just adjust the expected output, I assume.

               Linus