Re: [PATCH v12 3/8] remote set-head: refactor for readability

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 15, 2024, 05:50 UTC
Message-ID: <xmqqjzd511wd.fsf@gitster.g>
In-Reply-To: <20241023153736.257733-4-bence@ferdinandy.com>

Bence Ferdinandy <bence@ferdinandy.com> writes:

Show 6 quoted lines

> Rename buf and buf2 to something more explanatory.
>
> Instead of calling get_main_ref_store(the_repository) multiple times,
> call it once and store in a new refs variable. Although this change
> probably offers some performance benefits, the main purpose is to
> shorten the line lengths of function calls using this variable.

Also two strbufs are renamed, which is in line with the objective of the other change---to make the resulting code easier to follow.

Looking good.

>     v9: - further improve readability by renaming buf, and buf2 consistently
>           with how patch 6 was already done

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.