Re: [PATCH v12 2/8] refs: atomically record overwritten ref in update_symref
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 16, 2024, 07:58 UTC
- Message-ID
- <xmqqbjyfzk2u.fsf@gitster.g>
- In-Reply-To
- <54677502-a08c-4920-9b08-13517c8f027a@ferdinandy.com>
Bence Ferdinandy <bence@ferdinandy.com> writes:
> Sorry, it's late. The above is slightly bollocks since fetch ignores > any set_head errors later :) > But the idea stands that if we can set the head, let's do it. > The previous head is not important enough to die on.
Yes, I didn't mean to suggest aborting the fetch. I just wanted to make sure we _react_ correctly to a failing call to read a symref, possibly because the refs/remotes/$there/HEAD (1) does not exist, or (2) is not a symbolic ref but signals that the other side has its HEAD detached. Treating any failure to read a symref as if the symref does not exist would miss the latter case.
Thanks.