Re: [PATCH v2 3/3] remote set-head: set followRemoteHEAD to "warn" if "always"
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Dec 4, 2024, 11:43 UTC
- Message-ID
- <cfd54be2-af8f-429f-a4c6-41f54c33c89c@app.fastmail.com>
- In-Reply-To
- <20241204104003.514905-3-bence@ferdinandy.com>
Hi
On Wed, Dec 4, 2024, at 11:39, Bence Ferdinandy wrote:
Show 12 quoted lines
> diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh > index 7411aa770d..daf70406be 100755 > --- a/t/t5505-remote.sh > +++ b/t/t5505-remote.sh > @@ -504,6 +504,17 @@ test_expect_success 'set-head --auto has no > problem w/multiple HEADs' ' > ) > ' > > +test_expect_success 'set-head changes followRemoteHEAD always to warn' ' > + ( > + cd test &&
I think you need to `cd` in a subshell here. See `t/README`, “Don't chdir around in tests.”.
> + git config set remote.origin.followRemoteHEAD "always" && > + git remote set-head --auto origin && > + git config get remote.origin.followRemoteHEAD >output &&
Nit: maybe `actual` instead of `output`? Just for uniformity.