Re: [PATCH v13 5/9] remote set-head: better output for --auto

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 19, 2024, 10:54 UTC
Message-ID: <xmqqiksjcx4e.fsf@gitster.g>
In-Reply-To: <D5Q32ODJM8P5.6VQ08LDQHPXS@ferdinandy.com>

"Bence Ferdinandy" <bence@ferdinandy.com> writes:

Show 7 quoted lines

> No, it is not, but it's also a mistake. It should be `updateres == 1`.
> refs_update_symref_extended outputs -1 for "not a symref" and 1 for any other
> error currently. Before I touched the code it was 1 for any error, so I left
> that as is. So we want to error out on set_head if we get a 1 and continue if
> we get 0 or -1 (and handle the difference in the report_set_head_auto).
>
> Thanks for noticing, I'll get that fixed in v14.

It is good that somebody noticed it (and it may have happened to be me), but if it is a "mistake" as you said, I wonder why none of your tests caught it. Do we have a gap in test coverage?

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.