Re: [PATCH v14 03/10] refs: standardize output of refs_read_symbolic_ref

>
> On Fri Nov 22, 2024 at 11:37, karthik nayak <karthik.188@gmail.com> wrote:
>> Bence Ferdinandy <bence@ferdinandy.com> writes:
>>
>> [snip]
>>
>>> diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
>>> index 38eb14d591..1809e3426a 100644
>>> --- a/refs/reftable-backend.c
>>> +++ b/refs/reftable-backend.c
>>> @@ -830,10 +830,12 @@ static int reftable_be_read_symbolic_ref(struct ref_store *ref_store,
>>>  		return ret;
>>>
>>>  	ret = reftable_stack_read_ref(stack, refname, &ref);
>>> -	if (ret == 0 && ref.value_type == REFTABLE_REF_SYMREF)
>>> +        if (ret)
>>> +                ret = -1;
>>> +        else if (ref.value_type == REFTABLE_REF_SYMREF)
>>>  		strbuf_addstr(referent, ref.value.symref);
>>> -	else
>>> -		ret = -1;
>>> +        else
>>> +                ret = NOT_A_SYMREF;
>>>
>>
>> I was building my series on top of this, and noticed whitespace issues
>> here. A simple way to check your series is to run:
>>
>>   $ git log --check --pretty=format:"---% h% s"
>
> I ran this on v15 and it didn't produce any output. I read what --check is in
> the manpages, although the format is a bit cryptic for me. What does that do
> exactly? 
>
> Anyhow if there was no output for v15 I should be fine, right?