Re: [PATCH v14 03/10] refs: standardize output of refs_read_symbolic_ref
- From
Bence Ferdinandy <bence@ferdinandy.com>
- Date
- Nov 26, 2024, 20:56 UTC
- Message-ID
- <D5WESFCCZ463.3RFWANEKVGBOU@ferdinandy.com>
- In-Reply-To
- <xmqqh67twypb.fsf@gitster.g>
On Tue Nov 26, 2024 at 21:02, Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
> karthik nayak <karthik.188@gmail.com> writes: > >> With v14, running `git log --check --pretty=format:"---% h% s" master..` >> gives me: >> ... >> --- fed56bc6cc refs: standardize output of refs_read_symbolic_ref >> refs/reftable-backend.c:833: indent with spaces. >> + if (ret) >> refs/reftable-backend.c:834: indent with spaces. >> + ret = -1; >> ... > > Thanks, the above matches what I saw in my message Bence responded > to (to which you are responding). I was unsure if/how the status of > each "diff --check" is propagated up to the driving "git log", but > the job is reading from the output of the command and not using the > exit status of "git log --check", so even if "git log --check" did > not signal a check failure with its status, it did not matter ;-) A > quick local check says "git log --check" does exit with 2 if there > is an offending commit in the range, so we should be OK.
Ok, so `git diff --check master` at least does produce the output for me, and now that you mentioned the exit code, I checked that even though I get zero output from git log --check, the exit code is indeed 2. So now I just don't get why I don't see any output ...