Re: [PATCH v4 01/12] pkt-line: extract set_packet_header()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 5, 2016, 16:31 UTC
- Message-ID
- <xmqqh9azxjmk.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <486BA59A-F53B-4893-AE37-8956FCDE7E22@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 6 quoted lines
> However, besides the bogus performance argument I introduced that function > to allow packet writs to fail using the `gentle` parameter: > http://public-inbox.org/git/D116610C-F33A-43DA-A49D-0B33958822E5%40gmail.com/ > > Would you be OK if I introduce packet_write_gently() that returns `0` if the > write was OK and `-1` if it failed?
Yes, I agree with you that it would be a good thing to have a _gently() variant that lets the caller deal with possible error conditions itself instead of dying.
Thanks.