Re: [PATCH v4 11/12] convert: add filter.<driver>.process option

From: Torsten Bögershausen <tboegi@web.de>
Date: Aug 5, 2016, 21:34 UTC
Message-ID: <2e13c31c-5ee2-890d-1268-98fb67aba1ea@web.de>
In-Reply-To: <20160803164225.46355-12-larsxschneider@gmail.com>

On 2016-08-03 18.42, larsxschneider@gmail.com wrote:

Show 8 quoted lines

> The filter is expected to respond with the result content in zero
> or more pkt-line packets and a flush packet at the end. Finally, a
> "result=success" packet is expected if everything went well.
> ------------------------
> packet:          git< SMUDGED_CONTENT
> packet:          git< 0000
> packet:          git< result=success\n
> ------------------------

I would really send the diagnostics/return codes before the content.

Show 6 quoted lines

> If the result content is empty then the filter is expected to respond
> only with a flush packet and a "result=success" packet.
> ------------------------
> packet:          git< 0000
> packet:          git< result=success\n
> ------------------------

Which may be:

packet: git< result=success\n packet: git< SMUDGED_CONTENT packet: git< 0000

or for an empty file:

packet: git< result=success\n packet: git< SMUDGED_CONTENT packet: git< 0000

or in case of an error: packet: git< result=reject\n # And this will not send the "0000" packet

Does this makes sense ?