Re: [PATCH v4 11/12] convert: add filter.<driver>.process option

From: Jeff King <peff@peff.net>
Date: Aug 3, 2016, 22:46 UTC
Message-ID: <20160803224619.bwtbvmslhuicx2qi@sigill.intra.peff.net>
In-Reply-To: <0E3FC781-1B2C-4341-9B7B-D9D836596A35@gmail.com>

On Wed, Aug 03, 2016 at 11:48:00PM +0200, Lars Schneider wrote:

Show 23 quoted lines

> OK. Is this the v2 discussion you are referring to?
> http://public-inbox.org/git/1461972887-22100-1-git-send-email-sbeller%40google.com/
> 
> What format do you suggest?
> 
> packet:          git< git-filter-protocol\n
> packet:          git< version=2\n
> packet:          git< capability=clean\n
> packet:          git< capability=smudge\n
> packet:          git< 0000
> 
> or
> 
> packet:          git< git-filter-protocol\n
> packet:          git< version=2\n
> packet:          git< capability\n
> packet:          git< clean\n
> packet:          git< smudge\n
> packet:          git< 0000
> 
> or  ... ?
> 
> I would prefer the first one, I think.

How about:

  version=2
  clean=true
  smudge=true
  0000

? Then we do not have to care about multiple "capability" keys (so something naively parsing this could just store them in a string list, for example).

You could also make "clean" a synonym for "clean=true" or something, and have:

  version=2
  clean
  smudge
  0000

but it's probably better to have the protocol err on the side of verbose-but-unambiguous. It's not like people are typing this routinely.

-Peff