Re: [PATCH v3 03/10] pkt-line: add packet_flush_gentle()
- From
Jakub Narębski <jnareb@gmail.com>
- Date
- Jul 30, 2016, 12:04 UTC
- Message-ID
- <41184531-d3c2-43c0-d3b8-23cc913dbf86@gmail.com>
- In-Reply-To
- <20160729233801.82844-4-larsxschneider@gmail.com>
W dniu 30.07.2016 o 01:37, larsxschneider@gmail.com pisze:
Show 5 quoted lines
> From: Lars Schneider <larsxschneider@gmail.com> > > packet_flush() would die in case of a write error even though for some callers > an error would be acceptable. Add packet_flush_gentle() which writes a pkt-line > flush packet and returns `0` for success and `1` for failure.
I think it should be packet_flush_gently(), as in "to flush gently", but this is only my opinion; I have not checked the naming rules and practices for the rest of Git codebase.
> > Signed-off-by: Lars Schneider <larsxschneider@gmail.com> > ---