Re: [PATCH v3 03/10] pkt-line: add packet_flush_gentle()

From: Lars Schneider <larsxschneider@gmail.com>
Date: Aug 1, 2016, 12:28 UTC
Message-ID: <4CDC1706-33FD-4525-8B32-800005F5855B@gmail.com>
In-Reply-To: <41184531-d3c2-43c0-d3b8-23cc913dbf86@gmail.com>

Show 12 quoted lines

> On 30 Jul 2016, at 14:04, Jakub Narębski <jnareb@gmail.com> wrote:
> 
> W dniu 30.07.2016 o 01:37, larsxschneider@gmail.com pisze:
>> From: Lars Schneider <larsxschneider@gmail.com>
>> 
>> packet_flush() would die in case of a write error even though for some callers
>> an error would be acceptable. Add packet_flush_gentle() which writes a pkt-line
>> flush packet and returns `0` for success and `1` for failure.
> 
> I think it should be packet_flush_gently(), as in "to flush gently",
> but this is only my opinion; I have not checked the naming rules and
> practices for the rest of Git codebase.

Agreed. This would match:

object.c:int type_from_string_gently(const char *str, ssize_t len, int gentle)

Thanks, Lars

Show 5 quoted lines

> 
>> 
>> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
>> ---
>