Re: [PATCH v3 2/6] commit: add amend suboption to --fixup to create amend! commit

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 4, 2021, 00:58 UTC
Message-ID: <xmqqh7lrg2g0.fsf@gitster.c.googlers.com>
In-Reply-To: <CAPig+cQcjUzXpW1OBCiEC3Sr13uyeesqK49KWmgnY1iHNnS2Rw@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> Hmm, I see. I didn't follow whatever discussion led to the decision to
> use this sort of prefix matching, but I have to wonder if it is a good
> idea.

Meaning --fixup=a:<commit> and --fixup=amend:<commit> do the same thing, until somebody invents --fixup=another:<commit> and makes the prefix 'a' no longer unique? I tend to agree that, especially with command line completion support with modern shells, such a prefix matching would not be necessary.

> Was the idea that it behave similarly to sequencer commands in
> `git rebase --interactive` which are often abbreviated to a single
> letter? I personally would feel much more comfortable requiring a
> full-word match for `amend` and `reword` at initial implementation.

Me too.