Re: [PATCH v3 2/6] commit: add amend suboption to --fixup to create amend! commit

From: Charvi Mendiratta <charvi077@gmail.com>
Date: Mar 4, 2021, 09:01 UTC
Message-ID: <CAPSFM5dXDdi9_RF7nK+JTgPUUfvY4j3AMuWVoqaY=3yhCBwyWA@mail.gmail.com>
In-Reply-To: <xmqqh7lrg2g0.fsf@gitster.c.googlers.com>

On Thu, 4 Mar 2021 at 06:28, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

>
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
> > Hmm, I see. I didn't follow whatever discussion led to the decision to
> > use this sort of prefix matching, but I have to wonder if it is a good
> > idea.
>
> Meaning --fixup=a:<commit> and --fixup=amend:<commit> do the same
> thing, until somebody invents --fixup=another:<commit> and makes the
> prefix 'a' no longer unique?  I tend to agree that, especially with
> command line completion support with modern shells, such a prefix
> matching would not be necessary.
>

Okay, so for now I think (as suggested), let's remove it and directly use "!strcmp()" only instead of "starts_with()". I agree that if we keep prefix matching or not, it will not matter much.

Thanks and Regards, Charvi