Re: [PATCH v4 2/6] commit: add amend suboption to --fixup to create amend! commit

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 15, 2021, 08:16 UTC
Message-ID: <CAPig+cSZ45ZKqFfzL01ZFFA=pkLRVuktLKhVC=_dPoXbHSBcBA@mail.gmail.com>
In-Reply-To: <CAPSFM5fQeB8dOQRzWkwAJCkHtNb2GXUWqgJUHCWoJh0vdDp_Fg@mail.gmail.com>

On Mon, Mar 15, 2021 at 3:59 AM Charvi Mendiratta <charvi077@gmail.com> wrote:

Show 9 quoted lines

> On Mon, 15 Mar 2021 at 04:37, Eric Sunshine <sunshine@sunshineco.com> wrote:
> > Likewise. If you're going to re-roll anyhow, the open-coded:
> > would be perfectly fine with me too (or any simple variation on that
> > theme). Whether or not it's worth re-rolling again, I leave up to you
> > and Junio.
>
> okay, I agree too. I have updated it in the re-roll.
>
> Thanks for all the detailed reviews and suggestions.

Thanks for patiently putting up with reviewers who sometimes have opposing or contradictory opinions and recommendations.