Re: [PATCH v4 0/6][Outreachy] commit: Implementation of "amend!" commit

From: Charvi Mendiratta <charvi077@gmail.com>
Date: Mar 11, 2021, 15:24 UTC
Message-ID: <CAPSFM5eDSwBO+PHNzjvLhuor4Cs6VSmu714T4aCF8mgjfDqwLw@mail.gmail.com>
In-Reply-To: <CAPig+cREZvoFLNNmZROXOP5EKW36L7SKQMjYJJTsbtMeiK2wNw@mail.gmail.com>

On Thu, 11 Mar 2021 at 13:36, Eric Sunshine <sunshine@sunshineco.com> wrote:

[...]

Show 5 quoted lines

> Thanks for re-rolling. I left some relatively minor comments on patch
> [2/6] and some substantial documentation-related comments on [6/6].
> (If you take my suggested documentation rewrites verbatim, you can
> have my Signed-off-by: along with them.)
>

Sure, I will add the Signed-off-by.

Thanks for all the suggestions, I will fix them and update in the next version.

Show 6 quoted lines

> One final request: Please consider using the --range-diff or
> --interdiff options or both when preparing your series with
> git-format-patch. Doing so can really help reviewers focus on the
> changes made from re-roll to re-roll without having to painstakingly
> re-read each patch in the series -- even if a patch didn't change --
> thus saving time.

Okay, I will add it next time.

Thanks and Regards, Charvi