Re: [PATCH v3 3/6] commit: add a reword suboption to --fixup

From: Charvi Mendiratta <charvi077@gmail.com>
Date: Mar 3, 2021, 07:33 UTC
Message-ID: <CAPSFM5cgwX+NfsJ7Rib9xk0RGhTo4C35s2vTRG_Qxny=mwPk0Q@mail.gmail.com>
In-Reply-To: <xmqqh7lura1j.fsf@gitster.c.googlers.com>

On Tue, 2 Mar 2021 at 00:11, Junio C Hamano <gitster@pobox.com> wrote:

[...]

Show 12 quoted lines

> > +     if (argc)
> > +             die(_("cannot combine reword option of --fixup with path %s"), *argv);
>
> I think our convention is to quote '%s' with a single-quote pair.
> See other error messages.
>
> commit.c:                       die_errno(_("could not read '%s'"), templat...
> commit.c:               die_errno(_("could not open '%s'"), git_path_commit...
> commit.c:       die(_("--author '%s' is not 'Name <email>' and matches no e...
> commit.c:               die(_("Invalid ignored mode '%s'"), ignored_arg);
> commit.c:               die(_("Invalid untracked files mode '%s'"), untrack...
> ...

I admit I forgot to add it. I will fix it.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.