Re: [PATCH v2 0/3] bitmap-format.txt: fix some formatting issues and include checksum info
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 7, 2022, 18:28 UTC
- Message-ID
- <xmqqfskgwcou.fsf@gitster.g>
- In-Reply-To
- <pull.1246.v2.git.1654623814.gitgitgadget@gmail.com>
"Abhradeep Chakraborty via GitGitGadget" <gitgitgadget@gmail.com> writes:
> There are some issues in the bitmap-format html page.
"First, it does not even exist!" before anything else ;-)
Show 9 quoted lines
> For example, some > nested lists are shown as top-level lists (e.g. [1]- Here > BITMAP_OPT_FULL_DAG (0x1) and BITMAP_OPT_HASH_CACHE (0x4) are shown as > top-level list). There is also a need of adding info about trailing checksum > in the docs. > > Changes since v1: > > * a new commit addressing bitmap-format.txt html page generation is added
Good.
> * Remove extra indentation from the previous change
Good.
> * elaborate more about the trailing checksum (as suggested by Kaartic)
Good.
Will take a look (and audiences are requested to do so, too).
Thanks.