Re: [PATCH v3 2/3] bitmap-format.txt: fix some formatting issues

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Date: Jun 15, 2022, 14:28 UTC
Message-ID: <20220615142804.69543-1-chakrabortyabhradeep79@gmail.com>
In-Reply-To: <YqlDlYHR1HBJRiDZ@nand.local>

Taylor Blau <me@ttaylorr.com> wrote:

> - Are the hard-tabs added in this file required for ASCIIDoc to treat it
>   correctly? They are a slight impediment to reading the source in my
>   editor, but it's not a huge deal. It would just be nice if we could
>   replace "\t" characters with two or four spaces or something.

No, it is not required for Asciidoc. But `git diff --check` was complaining against it. Don't know if that is related to my git configuration settings. Moreover other parts of the file didn't seem to use spaces. For these reasons, I used tabs. But can remove it if you say.

> - The above hunk is the only one which rendered slightly oddly to me; it
>   looks like the paragraph beginning with "The obvious consequence ..."
>   is surrounded by a <pre> element, when it should be a continuation of
>   the above paragraph ("In each bitmap ...").

Thanks for pointing out. Don't know how it was missed. Correcting it.

Thanks :)