git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/3] bitmap-format.txt: fix some formatting issues

From
Abhradeep Chakraborty via GitGitGadget <gitgitgadget@gmail.com>
Date
Jun 10, 2022, 10:54 UTC
Message-ID
<c74b9a52c2a7b5f3ebbfaca08c8de42aac7f7eac.1654858481.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1246.v3.git.1654858481.gitgitgadget@gmail.com>
From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>

The asciidoc generated html for `Documentation/technical/bitmap- format.txt` is broken. This is mainly because `-` is used for nested lists (which is not allowed in asciidoc) instead of `*`.

Fix these and also reformat it for better readability of the html page.
Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
---
 Documentation/technical/bitmap-format.txt | 109 ++++++++++++----------
 1 file changed, 58 insertions(+), 51 deletions(-)
diff --git a/Documentation/technical/bitmap-format.txt b/Documentation/technical/bitmap-format.txt
index 04b3ec21785..cd621379f42 100644
--- a/Documentation/technical/bitmap-format.txt
+++ b/Documentation/technical/bitmap-format.txt
@@ -39,19 +39,22 @@ MIDXs, both the bit-cache and rev-cache extensions are required.
 
 == On-disk format
 
-	- A header appears at the beginning:
+	* A header appears at the beginning:
 
-		4-byte signature: {'B', 'I', 'T', 'M'}
+		4-byte signature: :: {'B', 'I', 'T', 'M'}
+
+		2-byte version number (network byte order): ::
 
-		2-byte version number (network byte order)
 			The current implementation only supports version 1
 			of the bitmap index (the same one as JGit).
 
-		2-byte flags (network byte order)
+		2-byte flags (network byte order): ::
 
 			The following flags are supported:
 
-			- BITMAP_OPT_FULL_DAG (0x1) REQUIRED
+			** {empty}
+			BITMAP_OPT_FULL_DAG (0x1) REQUIRED: :::
+
 			This flag must always be present. It implies that the
 			bitmap index has been generated for a packfile or
 			multi-pack index (MIDX) with full closure (i.e. where
@@ -61,75 +64,79 @@ MIDXs, both the bit-cache and rev-cache extensions are required.
 			JGit, that greatly reduces the complexity of the
 			implementation.
 
-			- BITMAP_OPT_HASH_CACHE (0x4)
+			** {empty}
+			BITMAP_OPT_HASH_CACHE (0x4): :::
+
 			If present, the end of the bitmap file contains
 			`N` 32-bit name-hash values, one per object in the
 			pack/MIDX. The format and meaning of the name-hash is
 			described below.
 
-		4-byte entry count (network byte order)
-
+		4-byte entry count (network byte order): ::
 			The total count of entries (bitmapped commits) in this bitmap index.
 
-		20-byte checksum
-
+		20-byte checksum: ::
 			The SHA1 checksum of the pack/MIDX this bitmap index
 			belongs to.
 
-	- 4 EWAH bitmaps that act as type indexes
-
-		Type indexes are serialized after the hash cache in the shape
-		of four EWAH bitmaps stored consecutively (see Appendix A for
-		the serialization format of an EWAH bitmap).
-
-		There is a bitmap for each Git object type, stored in the following
-		order:
-
-			- Commits
-			- Trees
-			- Blobs
-			- Tags
-
-		In each bitmap, the `n`th bit is set to true if the `n`th object
-		in the packfile or multi-pack index is of that type.
-
-		The obvious consequence is that the OR of all 4 bitmaps will result
-		in a full set (all bits set), and the AND of all 4 bitmaps will
-		result in an empty bitmap (no bits set).
-
-	- N entries with compressed bitmaps, one for each indexed commit
-
-		Where `N` is the total amount of entries in this bitmap index.
-		Each entry contains the following:
-
-		- 4-byte object position (network byte order)
+	* 4 EWAH bitmaps that act as type indexes
++
+Type indexes are serialized after the hash cache in the shape
+of four EWAH bitmaps stored consecutively (see Appendix A for
+the serialization format of an EWAH bitmap).
++
+There is a bitmap for each Git object type, stored in the following
+order:
++
+	- Commits
+	- Trees
+	- Blobs
+	- Tags
+
++
+In each bitmap, the `n`th bit is set to true if the `n`th object
+in the packfile or multi-pack index is of that type.
+
+    The obvious consequence is that the OR of all 4 bitmaps will result
+    in a full set (all bits set), and the AND of all 4 bitmaps will
+    result in an empty bitmap (no bits set).
+
+	* N entries with compressed bitmaps, one for each indexed commit
++
+Where `N` is the total amount of entries in this bitmap index.
+Each entry contains the following:
+
+		** {empty}
+		4-byte object position (network byte order): ::
 			The position **in the index for the packfile or
 			multi-pack index** where the bitmap for this commit is
 			found.
 
-		- 1-byte XOR-offset
+		** {empty}
+		1-byte XOR-offset: ::
 			The xor offset used to compress this bitmap. For an entry
 			in position `x`, a XOR offset of `y` means that the actual
 			bitmap representing this commit is composed by XORing the
 			bitmap for this entry with the bitmap in entry `x-y` (i.e.
 			the bitmap `y` entries before this one).
-
-			Note that this compression can be recursive. In order to
-			XOR this entry with a previous one, the previous entry needs
-			to be decompressed first, and so on.
-
-			The hard-limit for this offset is 160 (an entry can only be
-			xor'ed against one of the 160 entries preceding it). This
-			number is always positive, and hence entries are always xor'ed
-			with **previous** bitmaps, not bitmaps that will come afterwards
-			in the index.
-
-		- 1-byte flags for this bitmap
++
+NOTE: This compression can be recursive. In order to
+XOR this entry with a previous one, the previous entry needs
+to be decompressed first, and so on.
++
+The hard-limit for this offset is 160 (an entry can only be
+xor'ed against one of the 160 entries preceding it). This
+number is always positive, and hence entries are always xor'ed
+with **previous** bitmaps, not bitmaps that will come afterwards
+in the index.
+
+		** {empty}
+		1-byte flags for this bitmap: ::
 			At the moment the only available flag is `0x1`, which hints
 			that this bitmap can be re-used when rebuilding bitmap indexes
 			for the repository.
 
-		- The compressed bitmap itself, see Appendix A.
+		** The compressed bitmap itself, see Appendix A.
 
 == Appendix A: Serialization format for an EWAH bitmap
 
-- 
gitgitgadget
Previous: Abhradeep Chakraborty via GitGitGadgetNext: Taylor Blau
Message 25 of 37 in “bitmap-format.txt: fix some formatting issues and include checksum info”
  1. 0/2 bitmap-format.txt: fix some formatting issues and include checksum infoAbhradeep Chakraborty via GitGitGadget, Jun 2, 2022
  2. 2/2 bitmap-format.txt: add information for trailing checksumAbhradeep Chakraborty via GitGitGadget, Jun 2, 2022
  3. 1/2 bitmap-format.txt: fix some formatting issuesAbhradeep Chakraborty via GitGitGadget, Jun 2, 2022
  4. Junio C HamanoJun 6, 2022
  5. Abhradeep ChakrabortyJun 7, 2022
  6. 0/3 bitmap-format.txt: fix some formatting issues and include checksum infoAbhradeep Chakraborty via GitGitGadget, Jun 7, 2022
  7. 3/3 bitmap-format.txt: add information for trailing checksumAbhradeep Chakraborty via GitGitGadget, Jun 7, 2022
  8. Taylor BlauJun 7, 2022
  9. Abhradeep ChakrabortyJun 8, 2022
  10. 2/3 bitmap-format.txt: fix some formatting issuesAbhradeep Chakraborty via GitGitGadget, Jun 7, 2022
  11. Taylor BlauJun 7, 2022
  12. Junio C HamanoJun 7, 2022
  13. Abhradeep ChakrabortyJun 8, 2022
  14. Abhradeep ChakrabortyJun 8, 2022
  15. 1/3 bitmap-format.txt: feed the file to asciidoc to generate htmlAbhradeep Chakraborty via GitGitGadget, Jun 7, 2022
  16. Junio C HamanoJun 7, 2022
  17. Abhradeep ChakrabortyJun 8, 2022
  18. Taylor BlauJun 7, 2022
  19. Junio C HamanoJun 7, 2022
  20. Taylor BlauJun 7, 2022
  21. Junio C HamanoJun 7, 2022
  22. Abhradeep ChakrabortyJun 8, 2022
  23. 0/3 bitmap-format.txt: fix some formatting issues and include checksum infoAbhradeep Chakraborty via GitGitGadget, Jun 10, 2022
  24. 1/3 bitmap-format.txt: feed the file to asciidoc to generate htmlAbhradeep Chakraborty via GitGitGadget, Jun 10, 2022
  25. 2/3 bitmap-format.txt: fix some formatting issuesAbhradeep Chakraborty via GitGitGadget, Jun 10, 2022
  26. Taylor BlauJun 15, 2022
  27. Abhradeep ChakrabortyJun 15, 2022
  28. 3/3 bitmap-format.txt: add information for trailing checksumAbhradeep Chakraborty via GitGitGadget, Jun 10, 2022
  29. Junio C HamanoJun 10, 2022
  30. Taylor BlauJun 15, 2022
  31. Junio C HamanoJun 15, 2022
  32. 0/3 bitmap-format.txt: fix some formatting issues and include checksum infoAbhradeep Chakraborty via GitGitGadget, Jun 16, 2022
  33. 1/3 bitmap-format.txt: feed the file to asciidoc to generate htmlAbhradeep Chakraborty via GitGitGadget, Jun 16, 2022
  34. 2/3 bitmap-format.txt: fix some formatting issuesAbhradeep Chakraborty via GitGitGadget, Jun 16, 2022
  35. 3/3 bitmap-format.txt: add information for trailing checksumAbhradeep Chakraborty via GitGitGadget, Jun 16, 2022
  36. Junio C HamanoJun 16, 2022
  37. Taylor BlauJun 16, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.