git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] bitmap-format.txt: fix some formatting issues and include checksum info

From
Taylor Blau <me@ttaylorr.com>
Date
Jun 15, 2022, 02:28 UTC
Message-ID
<YqlD2qtwqmIKG9lo@nand.local>
In-Reply-To
<xmqq8rq4fo6p.fsf@gitster.g>
On Fri, Jun 10, 2022 at 10:01:02AM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> "Abhradeep Chakraborty via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > There are some issues in the bitmap-format html page. For example, some
> > nested lists are shown as top-level lists (e.g. [1]- Here
> > BITMAP_OPT_FULL_DAG (0x1) and BITMAP_OPT_HASH_CACHE (0x4) are shown as
> > top-level list). There is also a need of adding info about trailing checksum
> > in the docs.
>
> Quite honestly, I am not sure if a piecemeal "let's make
> <pre>...</pre> a bit prettier" is worth our time.  Especially
> relative to the importance of adding missing information to the
> documentation.
>
> So, if this round (I haven't looked at the formatting changes at all
> yet) turns out to be still not doing the HTML properly, I'd suggest
> shuffling the patches around, add missing information so that readers
> can get the corrections in text regardless of the rest of HTMLify
> effort.  We'll see.

This version of the series significantly improves the readability of the generated HTML, and I only had a minor comment or two.

So I think that the improvement is worthwhile, though if others disagree strongly, the third patch should get picked up regardless, since it addresses a legitimate gap in our documentation.

Thanks, Taylor

Previous: Junio C HamanoNext: Junio C Hamano
Message 30 of 37 in “bitmap-format.txt: fix some formatting issues and include checksum info”
  1. 0/2 bitmap-format.txt: fix some formatting issues and include checksum infoAbhradeep Chakraborty via GitGitGadget, Jun 2, 2022
  2. 2/2 bitmap-format.txt: add information for trailing checksumAbhradeep Chakraborty via GitGitGadget, Jun 2, 2022
  3. 1/2 bitmap-format.txt: fix some formatting issuesAbhradeep Chakraborty via GitGitGadget, Jun 2, 2022
  4. Junio C HamanoJun 6, 2022
  5. Abhradeep ChakrabortyJun 7, 2022
  6. 0/3 bitmap-format.txt: fix some formatting issues and include checksum infoAbhradeep Chakraborty via GitGitGadget, Jun 7, 2022
  7. 3/3 bitmap-format.txt: add information for trailing checksumAbhradeep Chakraborty via GitGitGadget, Jun 7, 2022
  8. Taylor BlauJun 7, 2022
  9. Abhradeep ChakrabortyJun 8, 2022
  10. 2/3 bitmap-format.txt: fix some formatting issuesAbhradeep Chakraborty via GitGitGadget, Jun 7, 2022
  11. Taylor BlauJun 7, 2022
  12. Junio C HamanoJun 7, 2022
  13. Abhradeep ChakrabortyJun 8, 2022
  14. Abhradeep ChakrabortyJun 8, 2022
  15. 1/3 bitmap-format.txt: feed the file to asciidoc to generate htmlAbhradeep Chakraborty via GitGitGadget, Jun 7, 2022
  16. Junio C HamanoJun 7, 2022
  17. Abhradeep ChakrabortyJun 8, 2022
  18. Taylor BlauJun 7, 2022
  19. Junio C HamanoJun 7, 2022
  20. Taylor BlauJun 7, 2022
  21. Junio C HamanoJun 7, 2022
  22. Abhradeep ChakrabortyJun 8, 2022
  23. 0/3 bitmap-format.txt: fix some formatting issues and include checksum infoAbhradeep Chakraborty via GitGitGadget, Jun 10, 2022
  24. 1/3 bitmap-format.txt: feed the file to asciidoc to generate htmlAbhradeep Chakraborty via GitGitGadget, Jun 10, 2022
  25. 2/3 bitmap-format.txt: fix some formatting issuesAbhradeep Chakraborty via GitGitGadget, Jun 10, 2022
  26. Taylor BlauJun 15, 2022
  27. Abhradeep ChakrabortyJun 15, 2022
  28. 3/3 bitmap-format.txt: add information for trailing checksumAbhradeep Chakraborty via GitGitGadget, Jun 10, 2022
  29. Junio C HamanoJun 10, 2022
  30. Taylor BlauJun 15, 2022
  31. Junio C HamanoJun 15, 2022
  32. 0/3 bitmap-format.txt: fix some formatting issues and include checksum infoAbhradeep Chakraborty via GitGitGadget, Jun 16, 2022
  33. 1/3 bitmap-format.txt: feed the file to asciidoc to generate htmlAbhradeep Chakraborty via GitGitGadget, Jun 16, 2022
  34. 2/3 bitmap-format.txt: fix some formatting issuesAbhradeep Chakraborty via GitGitGadget, Jun 16, 2022
  35. 3/3 bitmap-format.txt: add information for trailing checksumAbhradeep Chakraborty via GitGitGadget, Jun 16, 2022
  36. Junio C HamanoJun 16, 2022
  37. Taylor BlauJun 16, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.