Re: [PATCH v2 3/3] bitmap-format.txt: add information for trailing checksum

From

Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>

Date

Jun 8, 2022, 16:15 UTC

Message-ID

<20220608161523.10359-1-chakrabortyabhradeep79@gmail.com>

In-Reply-To

<Yp+7aXdaCX3Fh9SE@nand.local>

Taylor Blau <me@ttaylorr.com> wrote:

> I assume by "Index checksum" you are referring to a checksum of the
> bitmap _index_'s contents. 

Yeah, I meant a checksum of the bitmap file's content.

> That term is used a little throughout
> pack-format.txt, but it's foreign to me. Assuming that's how you meant
> it, a more conventional term (I think) would be just "trailing
> checksum".

> It is also not guaranteed to be a SHA-1 checksum, if the repository
> which wrote the bitmap is in SHA-256 mode. So I would suggest that this
> addition just read:
>
>     * TRAILER:
>
>       Trailing checksum of the preceding contents.

Got it. Thanks !