Re: [PATCH v2] commit-reach: remove get_reachable_subset()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 12, 2026, 14:41 UTC
- Message-ID
- <xmqqecibizwz.fsf@gitster.g>
- In-Reply-To
- <aivQv5FkTEWDn22i@wyuan.org>
Weijie Yuan <wy@wyuan.org> writes:
Show 7 quoted lines
> On Thu, Jun 11, 2026 at 10:48:18AM -0700, Junio C Hamano wrote: >> I wonder if we should talk about it in the SubmittingPatches and/or >> MyFirstContribution document? > > Hi, I think it might be a good idea to cover these details in > MyFirstContribution, then cross-reference them from the part of > SubmittingPatches that discusses sending a new version.
Sorry to be nitpicky, but the above is omitting too much from your quote. "it" in "talk about it" is totally unclear to a reader who haven't seen the message you are replying to.
> Also, for the part about sending a new version, I wonder whether it > would be better to summarize and fold in Patrick's explanation here, > thank you Patrick:
Yup, that is a great example.
> From: Patrick Steinhardt <ps@pks.im> > Message-ID: <aietF4BX1Ewt3cpG@pks.im>