Re: [PATCH v2] commit-reach: remove get_reachable_subset()
- From
- Weijie Yuan <wy@wyuan.org>
- Date
- Jun 12, 2026, 09:26 UTC
- Message-ID
- <aivQv5FkTEWDn22i@wyuan.org>
- In-Reply-To
- <xmqq7bo5nf31.fsf@gitster.g>
On Thu, Jun 11, 2026 at 10:48:18AM -0700, Junio C Hamano wrote:
> I wonder if we should talk about it in the SubmittingPatches and/or > MyFirstContribution document?
Hi, I think it might be a good idea to cover these details in MyFirstContribution, then cross-reference them from the part of SubmittingPatches that discusses sending a new version.
More specifically, I think these details could fit around steps 3 and 4 of "A typical life cycle of a patch series" in SubmittingPatches, starting around line 54. That section may need some reworking of the existing wording, rather than just an additive change.
Also, for the part about sending a new version, I wonder whether it would be better to summarize and fold in Patrick's explanation here, thank you Patrick:
---
From: Patrick Steinhardt <ps@pks.im> Message-ID: <aietF4BX1Ewt3cpG@pks.im>
> By the way, how long should I wait before sending new versions of my > patches? I have 4 outstanding at the moment.
I typically aim to send at most one version per day per patch series. This avoids that you're "flooding" the mailing list with too many versions of the same series, allows you to address feedback from multiple folks in batches, and it gives you enough time to think about the feedback without having to rush anything.
Whether I actually do end up sending a series depends on a couple of factors:
- How big is the series? The bigger it is the more time I give folks
to perform reviews. - How substantial were the reviews you received? Is it just a couple
of small typos? Then it probably makes sense to wait one or two more
days to get some more involved reviews. Is it something that
requires signifciant rework? Then I'd send out soon so that others
don't review a patch series that will change significantly anyway. - How close to being merged is the series? The closer it is the less
substantial the reviews will (hopefully) get, so it makes sense to
reroll a bit faster even if you only received minor feedback.So there isn't really a golden rule to follow here, but a lot of this depends on gut feeling. You probably won't have that feeling yet when starting out in a new project, but that's fine. In case we see that behaviour doesn't quite match the norm we'll typically give a hint that the contributor should slow down or maybe send a new iteration.
Patrick
---
Patrick's point may be beyond the scope of this thread, so I only mention it as an aside. Maybe these could be part of the same series.
Thanks.