Re: [PATCH v2] commit-reach: remove get_reachable_subset()
- From
Kristofer Karlsson <krka@spotify.com>
- Date
- Jun 11, 2026, 13:52 UTC
- Message-ID
- <CAL71e4Nn8Lk87A5=t1Wu=SStQqzmFqad+pcyOw_Fu-PLpRMq_g@mail.gmail.com>
- In-Reply-To
- <ffaf26b1-c55e-43c7-84b6-f810a54f7717@gmail.com>
On Thu, 11 Jun 2026 at 14:57, Derrick Stolee <stolee@gmail.com> wrote:
Show 7 quoted lines
> Finally, a commentary: You seem to have a habit of responding to > review feedback only through new patch versions, but I'd rather see > some thoughts in the discussion thread as direct replies to the review, > especially if you think you will change direction like this. Saying > something like "Maybe I should update the method to have two walk modes" > in a reply would have given me an opportunity to respond and perhaps > avoided a new version that went in this direction.
That's fair, I apologize both for jumping ahead too quickly with a new patch and also for evolving it into multiple logical changes (both code removal and complex refactoring).
I will be more mindful going forward about letting the discussion settle more before submitting followup patches.
I have no strong opinion on how to proceed - either park/abandon this or go with v1 as-is. I think you're right that having two modes within tips_reachable_from_bases is reducing the win here unless the mode is truly seamless but the abstraction does leak through a bit.
Thanks, Kristofer