git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] commit-reach: remove get_reachable_subset()

From
Derrick Stolee <stolee@gmail.com>
Date
Jun 11, 2026, 12:57 UTC
Message-ID
<ffaf26b1-c55e-43c7-84b6-f810a54f7717@gmail.com>
In-Reply-To
<pull.2144.v2.git.1781178567862.gitgitgadget@gmail.com>
On 6/11/2026 7:49 AM, Kristofer Karlsson via GitGitGadget wrote:
> From: Kristofer Karlsson <krka@spotify.com>
>      * Added PQ mode to the existing test-reach tests so both DFS and PQ
>        paths are exercised by the test suite.

This is a substantial change that I don't think is merited. I think that this makes the point of your change moot: we essentially have two implementations in one complicated method instead of two implementations that have different performance characteristics.

I'd rather leave the code as-is than take this complication. I don't think your commit message justifies the merging of these implementations, either.

Moreover, I thought the previous patch was fine, it just needed better awareness of the performance implications of the change. Specifically, it could be a regression for large repos without a commit-graph file while simultaneously potentially being a performance boost for large repos _with_ a commit-graph file.

_If_ we were to go this direction, then it should be two patches, with the first introducing the new mode and testing it. The second patch could change the callers of get_reachable_subset() and delete that code.

Finally, a commentary: You seem to have a habit of responding to review feedback only through new patch versions, but I'd rather see some thoughts in the discussion thread as direct replies to the review, especially if you think you will change direction like this. Saying something like "Maybe I should update the method to have two walk modes" in a reply would have given me an opportunity to respond and perhaps avoided a new version that went in this direction.

Thanks, -Stolee

Previous: Kristofer Karlsson via GitGitGadgetNext: Kristofer Karlsson
Message 6 of 14 in “commit-reach: remove get_reachable_subset()”
  1. commit-reach: remove get_reachable_subset()Kristofer Karlsson via GitGitGadget, Jun 9, 2026
  2. Junio C HamanoJun 10, 2026
  3. Kristofer KarlssonJun 10, 2026
  4. Derrick StoleeJun 10, 2026
  5. commit-reach: remove get_reachable_subset()Kristofer Karlsson via GitGitGadget, Jun 11, 2026
  6. Derrick StoleeJun 11, 2026
  7. Kristofer KarlssonJun 11, 2026
  8. Derrick StoleeJun 11, 2026
  9. Junio C HamanoJun 11, 2026
  10. Weijie YuanJun 12, 2026
  11. Junio C HamanoJun 12, 2026
  12. Weijie YuanJun 12, 2026
  13. Weijie YuanJun 12, 2026
  14. Kristofer KarlssonJun 15, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.