Re: [PATCH v2] commit-reach: remove get_reachable_subset()
- From
Kristofer Karlsson <krka@spotify.com>
- Date
- Jun 15, 2026, 20:58 UTC
- Message-ID
- <CAL71e4P3Oq08xVPZ+dxQ8L5PKekPJN0RsL4pTicom1og7-1D=A@mail.gmail.com>
- In-Reply-To
- <xmqq7bo5nf31.fsf@gitster.g>
I think we should park or abandon this patch for now; I initially thought it would be a somewhat cheap win in code reduction but the risk of introducing performance regressions for repos without commit graphs means it's not really worth the time investment and I don't want to add more maintainer burden for tracking it.
Thanks for looking at it though, I appreciate it! Kristofer
On Thu, 11 Jun 2026 at 19:48, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> > Derrick Stolee <stolee@gmail.com> writes: > > > Finally, a commentary: You seem to have a habit of responding to > > review feedback only through new patch versions, but I'd rather see > > some thoughts in the discussion thread as direct replies to the review, > > especially if you think you will change direction like this. Saying > > something like "Maybe I should update the method to have two walk modes" > > in a reply would have given me an opportunity to respond and perhaps > > avoided a new version that went in this direction. > > Thanks for saying this. > > I haven't (yet) found it in my exchange with Kristofer, but I did > find similar irritations during review sessions with other > contributors. > > I wonder if we should talk about it in the SubmittingPatches and/or > MyFirstContribution document?