Re: [PATCH v2] commit-reach: remove get_reachable_subset()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 11, 2026, 17:48 UTC
- Message-ID
- <xmqq7bo5nf31.fsf@gitster.g>
- In-Reply-To
- <ffaf26b1-c55e-43c7-84b6-f810a54f7717@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 7 quoted lines
> Finally, a commentary: You seem to have a habit of responding to > review feedback only through new patch versions, but I'd rather see > some thoughts in the discussion thread as direct replies to the review, > especially if you think you will change direction like this. Saying > something like "Maybe I should update the method to have two walk modes" > in a reply would have given me an opportunity to respond and perhaps > avoided a new version that went in this direction.
Thanks for saying this.
I haven't (yet) found it in my exchange with Kristofer, but I did find similar irritations during review sessions with other contributors.
I wonder if we should talk about it in the SubmittingPatches and/or MyFirstContribution document?