Re: [PATCH v2 2/2] Makefile: add style build rule

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 14, 2017, 22:25 UTC
Message-ID: <xmqqd17xu6qg.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170814213046.107576-3-bmwill@google.com>

Brandon Williams <bmwill@google.com> writes:

Show 20 quoted lines

> Add the 'style' build rule which will run git-clang-format on the diff
> between HEAD and the current worktree.  The result is a diff of
> suggested changes.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index ba4359ef8..acfd096b7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2414,6 +2414,10 @@ $(SP_OBJ): %.sp: %.c GIT-CFLAGS FORCE
>  .PHONY: sparse $(SP_OBJ)
>  sparse: $(SP_OBJ)
>  
> +.PHONY: style
> +style:
> +	git clang-format --style file --diff --extensions c,h

Did we get "git clang-format" subcommand, or is "s/git //" implied somewhere?

> +
>  check: common-cmds.h
>  	@if sparse; \
>  	then \