Re: [PATCH v2 0/2] clang-format

From: Brandon Williams <bmwill@google.com>
Date: Aug 14, 2017, 21:32 UTC
Message-ID: <20170814213251.GA95777@google.com>
In-Reply-To: <20170814213046.107576-1-bmwill@google.com>

On 08/14, Brandon Williams wrote:

Show 11 quoted lines

> Changes in v2:
>  * Changed a couple rules to be more inline with our coding style.
>  * Added a Makefile build rule to run git-clang-format on the diff of the
>    working tree to suggest style changes.
> 
> I found that the llvm project also has the git-clang-format tool which will
> allow for doing formating changes based on diffs so that the parts of the code
> you didn't touch won't be formated.  It also has a nice '-p' option to only
> apply hunks of suggested changes.  I also saw what Ramsay did and attempted to
> add a Makefile rule to run clang-format.  This bit may need more tweaking to
> get it right.

Forgot to include the [RFC] bit because from the discussion it seems like we still have a lot to talk about before we decide that this is the path we are taking.

Show 13 quoted lines

> 
> Brandon Williams (2):
>   clang-format: outline the git project's coding style
>   Makefile: add style build rule
> 
>  .clang-format | 165 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  Makefile      |   4 ++
>  2 files changed, 169 insertions(+)
>  create mode 100644 .clang-format
> 
> -- 
> 2.14.1.480.gb18f417b89-goog
>

-- 
Brandon Williams