Re: [RFC] clang-format: outline the git project's coding style

From: Jeff King <peff@peff.net>
Date: Aug 13, 2017, 04:41 UTC
Message-ID: <20170813044145.xz4o47oog3z5eycg@sigill.intra.peff.net>
In-Reply-To: <xmqq378xxuvk.fsf@gitster.mtv.corp.google.com>

On Fri, Aug 11, 2017 at 09:39:11PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> > Yeah, I just dug in the archive. The script I ran way back when was
> > actually clang-format-diff.
> 
> I am confident with the competence of people around here that we can
> come up with a reasonable checker for obvious style violations. In
> the worst case, we could customize and/or tweak checkpatch.pl and
> start from there.

I am confident we _can_, too. My question is whether we will. :)

Show 6 quoted lines

> Assuming that we can have such a checker, I am more interested in
> the way how people envision such a checker fits in our workflow to
> help people.  Earlier Dscho floated an idea to integrate with the
> GitHub pull requests in a way similar to how Travis and SubmitGit
> are triggered, and I can sort of see how it may help, but I haven't
> seen ideas from others.

Yeah, I agree. I assume most people already run "make test" locally. I'd be happy enough if we started with a "make style" that offers style suggestions for you to accept. From there we can grow into "automatically apply suggestions" and integrating with things like submitGit.

-Peff